Improve performance in ActiveStorage::Service::MirrorService
#51740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -30,6 +30,13 @@ def self.build(primary:, mirrors:, name:, configurator:, **options) # :nodoc: | |||
|
|
|||
| def initialize(primary:, mirrors:) | |||
| @primary, @mirrors = primary, mirrors | |||
| @executor = Concurrent::ThreadPoolExecutor.new( | |||
There was a problem hiding this comment.
Can you do a performance benchmarking?
There was a problem hiding this comment.
Sure! I'll add performance benchmark and request review to you.
There was a problem hiding this comment.
@akhilgkrishnan
This is performance benchmark using GCS. In my opinion, there is a performance improvement when looking at real time.
-
repeat time: 10
-
Used service: Google Cloud Storage (region: ap-northeast-3)
-
Used image size: 512kb
-
primary: 1, mirrors: 2
| Task | Real Time | User Time | System Time | Total Time |
|---|---|---|---|---|
| Parallel | 0.453 | 0.055 | 0.015 | 0.070 |
| Sequential | 0.979 | 0.045 | 0.011 | 0.056 |
- primary: 1, mirrors: 1
| Task | Real Time | User Time | System Time | Total Time |
|---|---|---|---|---|
| Parallel | 0.380 | 0.053 | 0.020 | 0.074 |
| Sequential | 0.624 | 0.033 | 0.008 | 0.041 |
There was a problem hiding this comment.
@akhilgkrishnan Could you please review when you get a chance? 😄
heka1024
force-pushed
the
parallel-upload-in-mirror-service
branch
from
00febe1
to
ecfbb5e
Compare
…ervice#delete` and `ActiveStorage::Service::MirrorService#delete_prefixed`
heka1024
force-pushed
the
parallel-upload-in-mirror-service
branch
from
ecfbb5e
to
3f2258a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
This Pull Request has been created to remove
FIXMEcomment ofActiveStorage::Service::MirrorService.Detail
This Pull Request use thread pool to parallelize
deleteanddelete_prefixedinActiveStorage::Service::MirrorService.Additional information
If this is a nit performance boost than complexity, how about remove comment?
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]