[Fix #51720] Infer association klass as top level if model has same demodularized name #51721
+53
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
Fixes #51720
Detail
Updates
AbstractReflection#klass
and its only subclass overrideMacroReflection#klass
to infer the association class as a top level class if the name of the model without module name-spacing is the same. The current inferrence is due to this logic resolving the name in the current module first, which doesn't make sense in this specific case as it will always resolve to the model itself.Additional information
None.
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]