Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow explicit loading of ActiveStorage routes #51716

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

justinko
Copy link
Contributor

@justinko justinko commented May 2, 2024

Fixes #31228

Motivation / Background

Users are creating a "catchall" route in routes.rb that will always precede the ActiveStorage routes. Railtie routes that are loaded after the app's routes are getting caught in it.

Detail

With this change, you can now load the routes when you want by doing the following:

Rails.application.config.active_storage.draw_routes = false

# in your routes.rb
Rails.application.routes.draw do
  ActiveStorage::Routes.draw(self)
end

Additional information

Should we do this for e.g. ActionMailbox as well?

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Unrelated changes should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • Tests are added or updated if you fix a bug or add a feature.
  • CHANGELOG files are updated for the changed libraries if there is a behavior change or additional feature. Minor bug fixes and documentation changes should not be included.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rails Router Catchall Picks Up ActiveStorage Routes
1 participant