Restart Action Cable when Redis reconnect_attempt limit is reached #51687
+49
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
This Pull Request has been created because when the ActionCable reconnect_attempt limit is reached, the server wedges and continues to accept connections but cannot deliver messages since Redis is disconnected.
Detail
This is based on #45478 and #44626 and building on #46562. #46562 added a Redis reconnect option, but when the number of reconnect attempts is exceeded the server cannot currently recover.
This Pull Request changes the ActionCable Redis subscription adapter to restart the ActionCable server when the number of reconnect_attempts is reached. The benefit of doing a restart is that it announces to the clients that the server is restarting. Combined with a health check that takes the server out of service (in the event of an extended Redis outage), this can allow clients to migrate to a healthy server.
cc @palkan @MrChrisW @engwan
Additional information
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]