forgetting_assignment should avoid serialization #44914
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akostadinov
force-pushed
the
main
branch
5 times, most recently
from
c154e0a to
4bc32f4
Compare
`#forgetting_assignment` was introduced with 07723c2, and it involved deserializing and then serializing current value. This is an unnecessary extra operation, and also it is a problem for custom attribute types where `#serialize` and `#deserialize` are not inverse to each other operations. This is a problem for example when using oracle-enhanced-adapter. fixes rails#44317 and rails#42738 and rsim/oracle-enhanced#2268
|
seems like things are more complicated than they appeared. Closing for now but input is welcome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#forgetting_assignmentwas introduced with 07723c2, and itinvolved deserializing and then serializing current value.
This is an unnecessary extra operation, and also it
is a problem for attribute types where
#serializeand#deserializeare not inverse to each other operations.This is a problem for example when using oracle-enhanced-adapter.
fixes #44317 and #42738 and rsim/oracle-enhanced#2268
Other Information