Implement SRI support in impotmaps-rails #304
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And add a new command to download and add integrity hashes for packages.
rafaelfranca
commented
Jul 9, 2025
| @@ -41,8 +41,60 @@ def pin_all_from(dir, under: nil, to: nil, preload: true) | |||
| # resolve for different asset hosts, you can pass in a custom `cache_key` to vary the cache used by this method for | |||
| # the different cases. | |||
| def preloaded_module_paths(resolver:, entry_point: "application", cache_key: :preloaded_module_paths) | |||
There was a problem hiding this comment.
This method can probably be deprecated now since the library isn't using anymore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces Subresource Integrity (SRI) support to the
importmap-railsgem, enhancing security by ensuring that JavaScript files loaded from CDNs have not been tampered with.Default behavior with integrity
When you pin a package, integrity hashes are automatically included:
This generates a pin in your
config/importmap.rbwith the integrity hash:Opting out of integrity
If you need to disable integrity checking (not recommended for security reasons), you can use the
--no-integrityflag:This generates a pin without integrity:
Adding integrity to existing pins
If you have existing pins without integrity hashes, you can add them using the
integritycommand:How integrity works
The integrity hashes are automatically included in your import map and module preload tags:
Import map JSON:
{ "imports": { "lodash": "https://ga.jspm.io/npm:[email protected]/lodash.js" }, "integrity": { "https://ga.jspm.io/npm:[email protected]/lodash.js": "sha384-PkIkha4kVPRlGtFantHjuv+Y9mRefUHpLFQbgOYUjzy247kvi16kLR7wWnsAmqZF" } }Module preload tags:
Modern browsers will automatically validate these integrity hashes when loading the JavaScript modules, ensuring the files haven't been modified.
Closes #297.