Update counter_cache even not reload #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@huacnlee CC |
huacnlee
reviewed
Nov 21, 2018
| return false if action.blank? | ||
| if defined_action[:counter_cache] && action.target.present? | ||
| target_count = Action.where( | ||
| action_type: defined_action[:action_type], | ||
| target_type: action.target_type, | ||
| target_id: action.target_id | ||
| ).count | ||
| action.target.update_attribute(defined_action[:counter_cache], target_count) | ||
| opts[:target].update_attribute(defined_action[:counter_cache], target_count) if opts[:target] |
There was a problem hiding this comment.
这里 target 有可能没有，有些时候传递的是 target_type 和 target_id
所以得用 action.target 稳妥些
看起来是 action_store 更新了数据，但内存中的 target 数据没变，得想其他方法来解决
抱歉，现在在看到这个 PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ruby-china/homeland#1054
解这里的bug，内存中 target user的
counter_cache没有得到刷新