[0.9 stable] Avoid loading ActionController::TestCase in production #2464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bf4
reviewed
Apr 9, 2024
casperisfine
force-pushed
the
0-9-stable-ac-test-case-lazy
branch
2 times, most recently
from
06263e0
to
078afe9
Compare
byroot
changed the title
casperisfine
force-pushed
the
0-9-stable-ac-test-case-lazy
branch
from
078afe9
to
f2e5cef
Compare
Ref: #3 > By referencing that object, it brings in all of the patches defined > in `ActionController::TestCase` to the development and production > environment, including behaviours like disabling the threading > implementation of `ActionController::Live`
casperisfine
force-pushed
the
0-9-stable-ac-test-case-lazy
branch
from
f2e5cef
to
39b538e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: Shopify#3
Extracted from: #2461
cc @bf4