Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Benchmark with cache that supports read-multi #1786

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bf4
Copy link
Member

@bf4 bf4 commented Jun 8, 2016

(needs to be rebased when #1785 is merged)

Just sharing in case anyone's interested in contributing ideas.

cc @sorentwo

  • fakeredis gem?
  • before/after benchmark

Benchmark command:

bin/bench -r 5

before

after

{
"commit_hash": "461ba7a",
"version": "0.10.0",
"rails_version": "4.2.6",
"benchmark_run[environment]": "2.2.3p173",
"runs": [
  {
    "benchmark_type[category]": "caching on: caching serializers: gc off",
    "benchmark_run[result][iterations_per_second]": 672.108,
    "benchmark_run[result][total_allocated_objects_per_iteration]": 1344
  },
  {
    "benchmark_type[category]": "caching on: fragment caching serializers:
gc off",
    "benchmark_run[result][iterations_per_second]": 498.769,
    "benchmark_run[result][total_allocated_objects_per_iteration]": 1779
  },
  {
    "benchmark_type[category]": "caching on: non-caching serializers: gc
off",
    "benchmark_run[result][iterations_per_second]": 970.039,
    "benchmark_run[result][total_allocated_objects_per_iteration]": 1230
  },
  {
    "benchmark_type[category]": "caching off: caching serializers: gc
off",
    "benchmark_run[result][iterations_per_second]": 588.077,
    "benchmark_run[result][total_allocated_objects_per_iteration]": 1344
  },
  {
    "benchmark_type[category]": "caching off: fragment caching
serializers: gc off",
    "benchmark_run[result][iterations_per_second]": 450.344,
    "benchmark_run[result][total_allocated_objects_per_iteration]": 1779
  },
  {
    "benchmark_type[category]": "caching off: non-caching serializers: gc
off",
    "benchmark_run[result][iterations_per_second]": 856.79,
    "benchmark_run[result][total_allocated_objects_per_iteration]": 1230
  }
]
}

currently intended to be used in #1781

@bf4 bf4 changed the title Benchmark with cache that supports read-multi WIP: Benchmark with cache that supports read-multi Jun 8, 2016
@bf4 bf4 force-pushed the bench_multi branch 2 times, most recently from 559108c to 126e771 Compare June 9, 2016 05:50
bin/bench -r 5

Benchmark results:
{
  "commit_hash": "617c8a7",
  "version": "0.10.0",
  "rails_version": "4.2.6",
  "benchmark_run[environment]": "2.2.3p173",
  "runs": [
    {
      "benchmark_type[category]": "caching on: caching serializers: gc off",
      "benchmark_run[result][iterations_per_second]": 669.362,
      "benchmark_run[result][total_allocated_objects_per_iteration]": 1341
    },
    {
      "benchmark_type[category]": "caching on: fragment caching serializers: gc off",
      "benchmark_run[result][iterations_per_second]": 628.208,
      "benchmark_run[result][total_allocated_objects_per_iteration]": 1433
    },
    {
      "benchmark_type[category]": "caching on: non-caching serializers: gc off",
      "benchmark_run[result][iterations_per_second]": 1008.955,
      "benchmark_run[result][total_allocated_objects_per_iteration]": 1230
    },
    {
      "benchmark_type[category]": "caching off: caching serializers: gc off",
      "benchmark_run[result][iterations_per_second]": 605.704,
      "benchmark_run[result][total_allocated_objects_per_iteration]": 1341
    },
    {
      "benchmark_type[category]": "caching off: fragment caching serializers: gc off",
      "benchmark_run[result][iterations_per_second]": 560.369,
      "benchmark_run[result][total_allocated_objects_per_iteration]": 1433
    },
    {
      "benchmark_type[category]": "caching off: non-caching serializers: gc off",
      "benchmark_run[result][iterations_per_second]": 868.604,
      "benchmark_run[result][total_allocated_objects_per_iteration]": 1230
    }
  ]
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant