support for afero.Fs filesystem abstraction #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jeff Lindsay <[email protected]>
… no meaningful working directory Signed-off-by: Jeff Lindsay <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
using this library alongside code that uses afero has been very difficult, so I decided to just add support. it adds a dependency (afero), but now you can using this against various afero filesystem implementations. by default, it uses
afero.OsFsso it behaves the same other than one thing:filesystem.Abshas been changed to justfilesystem.Cleanbecause there is no concept of working directory when working with abstraction filesystems.i don't know whether to vendor this change and keep it to myself or if the added dependency and slight change in behavior is worth merging. but the option is here if nothing else as a reference for others needing to do the same.
[recreating to live on a non-master branch in my fork]