[ABW-2893] use dapp_definition instead of dapp_definitions for component resolution #782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakub-rdx
changed the title
raf-rdx
approved these changes
Feb 1, 2024
micbakos-rdx
approved these changes
Feb 1, 2024
| @@ -31,6 +32,9 @@ data class DApp( | |||
| val definitionAddresses: List<String> | |||
There was a problem hiding this comment.
@jakub-rdx I think this will be unused. Why not replacing
val definitionAddress: String?
get() = metadata.dAppDefinition()
Having two methods slightly renamed will be confusing in the future.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Our current main branch already works, but:
dapp_definitionsand usedapp_definitionas a fallback. I changed it so that we usedapp_definition, similar as iOS does.How to test
Using dApps section is presentPR submission checklist