Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ABW-2739] Fix settings transition inconsistency #780

Merged
merged 1 commit into from
Feb 1, 2024
Merged

[ABW-2739] Fix settings transition inconsistency #780

merged 1 commit into from
Feb 1, 2024

Conversation

jakub-rdx
Copy link
Contributor

@jakub-rdx jakub-rdx commented Jan 31, 2024 •
edited
Loading

Description

See this for video on how to reproduce on main

  • update compose libraries
  • set same transitions for settings
  • set fillMaxSize() on every settings screen, as this was apparently interfering with proper animation sometimes

How to test

  1. Before the change, quickly click on 1st level settings item, tap back and repeat this as fast as possible cycling through settings.
  2. One attempt in few results in weird diagonal transition.

PR submission checklist

  • I have tested settings transition.
  • I have tested switching tabs on account details and scrolling NFT collection - those two issues we had with past compose library versions.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 31, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@jakub-rdx jakub-rdx merged commit d3b1d38 into main Feb 1, 2024
9 checks passed
@jakub-rdx jakub-rdx deleted the fix/ABW-2739-settings-transition branch February 1, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micbakos-rdx micbakos-rdx micbakos-rdx approved these changes

@raf-rdx raf-rdx raf-rdx approved these changes

@giannis-rdx giannis-rdx Awaiting requested review from giannis-rdx

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jakub-rdx @raf-rdx @micbakos-rdx