Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dashboard link bugs #778

Merged
merged 2 commits into from
Jan 31, 2024
Merged

Dashboard link bugs #778

merged 2 commits into from
Jan 31, 2024

Conversation

micbakos-rdx
Copy link
Contributor

Description

  1. Links to pool addresses resolve to the correct page
  2. Resource addresses and local ids for newly created entities do not show the View in Radix Dashboard action.

How to test

  1. Do a pool contribution or redemption. Click on the pools sheet and visit the dashboard for a pool address
  2. Create a token or an NFT and long click on the resource address or also the local id for the NFT. All should not show the View in Radix Dashboard action.

PR submission checklist

  • I have tested account to account transfer flow and have confirmed that it works

@micbakos-rdx micbakos-rdx self-assigned this Jan 30, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 30, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

20.0% Coverage on New Code (required ≥ 40%)

See analysis details on SonarCloud

@micbakos-rdx micbakos-rdx merged commit 5121f27 into main Jan 31, 2024
8 of 9 checks passed
@micbakos-rdx micbakos-rdx deleted the bugfix/ABW-2897-dashboard-links branch January 31, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakub-rdx jakub-rdx jakub-rdx approved these changes

@raf-rdx raf-rdx raf-rdx approved these changes

@giannis-rdx giannis-rdx Awaiting requested review from giannis-rdx

Assignees

@micbakos-rdx micbakos-rdx

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@micbakos-rdx @raf-rdx @jakub-rdx