[ABW-2889] properly compute unstake values. #777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakub-rdx
changed the title
jakub-rdx
force-pushed
the
fix/ABW-2889-unstake-values-fix
branch
from
ced05a9
to
7453d87
Compare
| val ownedAccount = getProfileUseCase.accountOnCurrentNetwork(depositsPerAddress.key) ?: error("No account found") | ||
| val deposits = depositsPerAddress.value.map { deposit -> | ||
| val resourceAddress = deposit.resourceAddress | ||
| val contributions = classification.poolContributions.filter { | ||
| it.poolUnitsResourceAddress.addressString() == resourceAddress | ||
| } | ||
| if (contributions.isEmpty()) { | ||
| resolveGeneralAsset(deposit, summary, assets, defaultDepositGuarantee) | ||
| resolveGeneralAsset(deposit, this, assets, defaultDepositGuarantee) | ||
| } else { | ||
| val pool = involvedPools.find { it.address == contributions.first().poolAddress.addressString() } |
There was a problem hiding this comment.
Improvement for the future:
These 6 lines could be also replaced if you didn't filter for involved pools only.
You could just find the pool unit by the resource address. Inside the pool unit object you have all you need.
- pool (with metadata and associated dapps)
- associated resources
- unit fungible
There was a problem hiding this comment.
makes sense. please verify if the recent change reflect what you had in mind
micbakos-rdx
requested changes
Jan 31, 2024
There was a problem hiding this comment.
I see wrong claim values again deposited to the accounts
Screen_recording_20240131_111029.webm
|
micbakos-rdx
approved these changes
Jan 31, 2024
raf-rdx
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
resolveAssetsFromAddressUseCaseinPoolContributionProcessor, drop separate calls to fetch poolsHow to test
Screenshot
PR submission checklist