Compute stake/pool preview guarantees state #774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micbakos-rdx
force-pushed
the
fix/ABW-2846-guarantees
branch
from
adee6f0
to
7270001
Compare
micbakos-rdx
approved these changes
Jan 29, 2024
| val resourceAddress = deposit.resourceAddress | ||
| val contributions = classification.poolContributions.filter { | ||
| it.poolUnitsResourceAddress.addressString() == resourceAddress | ||
| } | ||
| if (contributions.isEmpty()) { | ||
| null | ||
| resolveGeneralAsset(deposit, summary, assets, defaultDepositGuarantee) |
There was a problem hiding this comment.
Why is this needed here? Can you explain when we have empty contributions?
There was a problem hiding this comment.
see second bullet
There was a problem hiding this comment.
if you contribute to pool amounts of resources that do not convert to pool units entirely (for example you have ratio of resources A:B as 1:2, and you contribute 1 unit of A and 2.5 of B (via sandbox), that reminder of 0.5 B is returned by RET as regular resource deposited to the specific account. Without that change, this is not reflected in the "Depositing" section, although you see in "Withdrawn" 2.5 of B being withdrawn.
...ylon/wallet/android/presentation/transaction/analysis/processor/PoolContributionProcessor.kt
Outdated
Show resolved
Hide resolved
micbakos-rdx
force-pushed
the
bugfix/ABW-2846-ui-discrepancies
branch
from
5016cc6
to
f31bd6b
Compare
jakub-rdx
force-pushed
the
fix/ABW-2846-guarantees
branch
from
bd8255a
to
39077c4
Compare
micbakos-rdx
approved these changes
Jan 30, 2024
raf-rdx
approved these changes
Jan 30, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TrackedClaimobject to produce model representing tx preview in that casePR submission checklist