Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow click on fungibles & NFTs from dApp details sheets #765

Merged
merged 2 commits into from
Jan 29, 2024

Conversation

micbakos-rdx
Copy link
Contributor

Description

DAppDetailsDialog is now able to click on the associated fungibles and non fungibles. Also the text changed to associated NFTs for the non fungibles section.

How to test

  1. Better use gumball club to do a transaction.
  2. Click on the Using dapps section
  3. Then click on a fungible or non fungible associated with gumball club

Video

dappdetails.webm

PR submission checklist

  • I have tested account to account transfer flow and have confirmed that it works

Copy link

sonarcloud bot commented Jan 24, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

0.0% Coverage on New Code (required ≥ 40%)
17.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@micbakos-rdx micbakos-rdx changed the title Bugfix/abw 2854 dapps entities Allow click on fungibles & NFTs from dApp details sheets Jan 25, 2024
@micbakos-rdx micbakos-rdx merged commit 3c2674f into main Jan 29, 2024
8 of 9 checks passed
@micbakos-rdx micbakos-rdx deleted the bugfix/ABW-2854-dapps-entities branch January 29, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants