ABW-2488 - Refactor around dApp Login Auth and UnAuth #747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing due to inactivity |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is Draft work for improving code around DAppAuthorizedLogin and DAppUnauthorizedLogin.
What I did so far is to find common code and I created delegate that serves this for both Authorised and Unauthorised view models.
Here are my findings:
WIth regards to Composable there isn't much code that can be reused. Let me know your thoughts if it makes sense to use One composable but I got a feeling that it will be just moving code around and having them split actually makes sense I think.
I tried to reuse as much as I could in View Models however I was hoping there will be more. Let me also know the way I did this with delegate is fine.
Would like to hear you thoughts on how else it can be improved in terms of common code for both authorised and unauthorised paths.