Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ABW-2555] Fix showing duplicate dev section #620

Merged

Conversation

jakub-rdx
Copy link
Contributor

@jakub-rdx jakub-rdx commented Nov 1, 2023

Description

Settings section are not data classes, so distinct() did not work and we need to explicitly check if dev section exist before adding it

How to test

  1. Edit account label and see dev section duplicated

PR submission checklist

  • I have verified that developer section shows only once in settings list

@jakub-rdx jakub-rdx changed the title fix showing duplicate dev section [ABW-2555] Fix showing duplicate dev section Nov 1, 2023
Copy link
Contributor

@raf-rdx raf-rdx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Copy link

sonarcloud bot commented Nov 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@jakub-rdx jakub-rdx merged commit bf6612f into main Nov 1, 2023
10 checks passed
@jakub-rdx jakub-rdx deleted the fix/ABW-2555-developer-section-added-multiple-times branch November 1, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants