[ABW-2554] update exception handling to properly show no mnemonic error #618
Conversation
jakub-rdx
changed the title
jakub-rdx
requested review from
micbakos-rdx,
giannis-rdx and
raf-rdx
and removed request for
micbakos-rdx
| @@ -158,6 +162,15 @@ private fun RevealSeedPhraseContent( | |||
| ) | |||
| } | |||
| } | |||
| if (BuildConfig.DEBUG_MODE) { | |||
There was a problem hiding this comment.
I've added debug button to copy whole seed phrase, this is really helpful when trying to input mnemonic quick for testing purposes, for example after backup restoration
There was a problem hiding this comment.
that's great
thanks! 🙌🏽
| @@ -259,17 +259,17 @@ class DAppAuthorizedLoginViewModel @Inject constructor( | |||
| if (exception.cause is RadixWalletException.SignatureCancelled) { | |||
| return | |||
| } | |||
| if (exception.cause is ProfileException.NoMnemonic) { | |||
There was a problem hiding this comment.
this is most important change in this PR, rest is just minor renaming
| @@ -158,6 +162,15 @@ private fun RevealSeedPhraseContent( | |||
| ) | |||
| } | |||
| } | |||
| if (BuildConfig.DEBUG_MODE) { | |||
There was a problem hiding this comment.
that's great
thanks! 🙌🏽
| @@ -727,7 +727,7 @@ class DAppAuthorizedLoginViewModel @Inject constructor( | |||
| sealed interface Event : OneOffEvent { | |||
|
|
|||
| data object CloseLoginFlow : Event | |||
| data class RequestCompletionBiometricPrompt(val requestDuringSigning: Boolean) : Event | |||
| data class RequestCompletionBiometricPrompt(val signatureRequired: Boolean) : Event | |||
There was a problem hiding this comment.
However let's keep it as we have in most of places with the prefix is -> isSignatureRequired.
a renaming is always a welcome improvement!
yes |
|
SonarCloud Quality Gate failed.
|
Description
No mnemonic exception was passed as a
causeof signature failure, so error handling flow in dapp login was wrong in this scenario.How to test
Please refer to Jira ticket, there are detailed steps to reproduce.
PR submission checklist