ABW-2346 - String copies imported from Crowdin. #605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raf-rdx
changed the title
raf-rdx
changed the title
# Conflicts: # app/src/main/java/com/babylon/wallet/android/data/transaction/DappRequestFailure.kt # app/src/main/java/com/babylon/wallet/android/presentation/common/UiMessage.kt # app/src/main/java/com/babylon/wallet/android/presentation/status/transaction/TransactionStatusDialog.kt
raf-rdx
changed the title
jakub-rdx
approved these changes
Nov 1, 2023
micbakos-rdx
approved these changes
Nov 1, 2023
|
SonarCloud Quality Gate failed.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added string copies from Crowding.
Still there will be something to replace when this gets merged -> radixdlt/apps-localization-src#220
How to test
Test in the same way as this PR -> #598
Although I don't think it is required as it is simply replacing hardcoded strings to Crowdin copies.
Screenshot
PR submission checklist