[ABW-3268] Rename link connector #1196
Conversation
| ) | ||
| IconButton( |
There was a problem hiding this comment.
The spacing between the 2 icon buttons is larger than what's in Zeplin. I think this is because of Modifier.minimumInteractiveComponentSize from inside IconButton implementation. We can easily override the size to match Zeplin.
There was a problem hiding this comment.
yup but there is a reason that the minimumInteractiveComponentSize exists, and that's because of accessibility.
Wouldn't be a bad idea to break this min size?
There was a problem hiding this comment.
You're right, in such case this has to be communicated to Aftab, I think it's good to take Zeplin as the single source of truth in terms of design, pixel-perfect if possible.
At the same time, I think minimizing the touch area from 48.dp to 40.dp would bring us to the desired outcome without sacrificing much in terms of the touch area (8.dp is a quite small and negligible difference in my opinion)
| textAlign = TextAlign.Center | ||
| ) | ||
| Spacer(modifier = Modifier.height(RadixTheme.dimensions.paddingLarge)) | ||
| RadixTextField( |
There was a problem hiding this comment.
It would be nice to make the name input start with uppercase:
keyboardOptions = KeyboardOptions.Default.copy(capitalization = KeyboardCapitalization.Words)
| val inputFocusRequester = remember { FocusRequester() } | ||
|
|
||
| LaunchedEffect(Unit) { | ||
| inputFocusRequester.requestFocus() |
There was a problem hiding this comment.
Nice! A nice touch is to make the selector show at the end of the current name in the text field, so the user can either remove or edit the current name without the extra tap to set the selector at the right position.
There was a problem hiding this comment.
I was really looking for exactly this! Any idea how to do it?
There was a problem hiding this comment.
The only way I know is to set selection to the text field value. As I see we're using OutlinedTextField, there is another composable for it that takes TextFieldValue type for the value param instead of String, where you can pass the selection index. Maybe we'd want our RadixTextField have a similar overloaded composable which would take a TextFieldValue param instead of String to be able to handle such cases.
There was a problem hiding this comment.
I see... thanks for the explanation.
However I see this as a separate task since I played around with the BasicTextField which can take a TextFieldValue as param, but needs more customization/styling in order to look the same as RadixTextField.
Therefore let's better take this in another ticket.
|
| @@ -169,6 +170,10 @@ class AccountSettingsViewModel @Inject constructor( | |||
| sendEvent(Event.AccountHidden) | |||
| } | |||
| } | |||
|
|
|||
| fun onSnackbarMessageShown() { | |||
There was a problem hiding this comment.
Should we rename it to something related to isAccountNameUpdated ?
Description
This PR adds functionality to rename link connectors.
Also minor update in Gateways screen based on zeplin screens.
How to test
➡️ Ensure that link connection has not been affected (e.g. terminated or restarted)
Video
Screen_Recording_20240913_123402_Radix.Wallet.Dev.mp4
PR submission checklist