Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate advanced lock flag from app preferences to profile #1184

Merged

Conversation

giannis-rdx
Copy link
Contributor

@giannis-rdx giannis-rdx commented Sep 9, 2024

Description

This PR migrates the advanced lock flag from app preferences to profile.

How to test

  1. Test it

PR submission checklist

  • I have tested lock screen with several flows
  • I have tested lock screen with restore from backup (with profile that has the advanced lock flag to true)

@@ -140,6 +140,8 @@ class MainActivity : FragmentActivity() {
viewModel.state.collect { state ->
if (state.isAdvancedLockEnabled) {
window.addFlags(WindowManager.LayoutParams.FLAG_SECURE)
} else {
window.clearFlags(WindowManager.LayoutParams.FLAG_SECURE)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

sonarcloud bot commented Sep 9, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 40%)

See analysis details on SonarCloud

@giannis-rdx giannis-rdx merged commit b80870f into main Sep 9, 2024
8 of 9 checks passed
@giannis-rdx giannis-rdx deleted the taskk/migrate-advancedlockflag-from-pref-to-profile branch September 9, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants