[ABW-1672] Add info popup #1169

giannis-rdx · 2024-08-30T12:18:23Z

Description

This PR adds info buttons and info dialogs. It also:

adds a separate composable for warnings: WarningText
adds a separate composable for info buttons: InfoButton
added InfoDialog composable screen that can be triggers from several places in the wallet (similar to asset dialogs)
several UI fixes based on Zeplin

How to test

Open Wallet and navigate to the screens that have a info button
click on this and click also on the other links inside the dialog
There are two types of links: web links that open the browser and the glossaryAnchors that update the content of the info dialog: See the video

Video

Screen_Recording_20240901_172302_Radix.Wallet.Dev.mp4

PR submission checklist

I have tested info buttons

app/src/main/java/com/babylon/wallet/android/presentation/dialogs/info/InfoDialog.kt

sergiupuhalschi-rdx · 2024-09-02T06:45:48Z

app/src/main/java/com/babylon/wallet/android/presentation/dialogs/info/InfoDialog.kt

+        onDismiss = onDismiss
+    ) {
+        InfoDialogContent(
+            scrollState = ScrollState(initial = 0),


Maybe rememberScrollState? I think this will also fix the issue of the scroll being reset (scrolled up) after clicking a URL and getting back to the app (or after pausing and resuming the app while the info pop up is displayed)

I did this on purpose for the glossary items. For example, when you click on XRD it will scroll to the top so you can see the content from the beginning.

Makes sense, then to improve this and also fix the issue I described maybe it's worth using rememberScrollState and scrolling to the top based on a boolean (using LaunchedEffect) only when tapping on a glossary item and not a URL.

did ti with a slightly different way

Even better!

app/src/main/java/com/babylon/wallet/android/presentation/dialogs/info/InfoDialog.kt

micbakos-rdx

The info links seem to have the wrong blue color. See an example here.

micbakos-rdx · 2024-09-02T08:52:58Z

app/src/main/java/com/babylon/wallet/android/presentation/dialogs/info/GlossaryItem.kt

@@ -0,0 +1,34 @@
+package com.babylon.wallet.android.presentation.dialogs.info
+
+// the enums are defined the same way they are written in Strings ("glossaryAnchor" tags)


Why did we need to define them that way? Does this have to do with serialization?

we are planning to define them in Sargon, and plus to easily get the valueOf based on the glossary anchor value.

micbakos-rdx · 2024-09-02T08:57:02Z

app/src/main/java/com/babylon/wallet/android/presentation/dialogs/info/InfoDialog.kt

+    val context = LocalContext.current
+
+    val customHeading2: MarkdownComponent = {
+        val content = it.content


I am a bit confused by it. Where does this come from?

this comes from the composable
typealias MarkdownComponent = @Composable ColumnScope.(MarkdownComponentModel) -> Unit
it is the MarkdownComponentModel.
I updated this part

sergiupuhalschi-rdx

Looks good!

app/src/main/java/com/babylon/wallet/android/presentation/dialogs/info/InfoDialog.kt

sergiupuhalschi-rdx · 2024-09-03T07:11:34Z

app/src/main/java/com/babylon/wallet/android/presentation/dialogs/info/InfoDialog.kt

@@ -132,7 +132,7 @@ private fun InfoDialogContent(
    Column(
        modifier = modifier
            .background(RadixTheme.colors.defaultBackground)
-            .fillMaxHeight(0.5f)
+            .fillMaxHeight(0.9f)


Now it looks way better!

micbakos-rdx · 2024-09-04T07:40:02Z

app/src/main/java/com/babylon/wallet/android/presentation/dialogs/info/InfoDialog.kt

@@ -153,6 +156,10 @@ private fun InfoDialogContent(
                override fun openUri(uri: String) {
                    if (uri.contains(GLOSSARY_ANCHOR)) {
                        onGlossaryItemClick(uri.drop(GLOSSARY_ANCHOR.length))
+                        coroutineScope.launch {
+                            // dialog updated with new glossary item therefore scroll to top
+                            scrollState.animateScrollTo(0)


sergiupuhalschi-rdx

If it's not a very difficult addition, it would be nice to display the title at the top of the info sheet when scrolling up and it's not visible anymore as part of the sheet content. This behavior is present on iOS and it looks good.

…y warnings

in TransactionReviewScreen

sonarcloud · 2024-09-06T14:43:11Z

Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 40%)

See analysis details on SonarCloud

giannis-rdx changed the title ~~Feature/abw 1672 add info popup~~ [ABW-1672] Add info popup Aug 30, 2024

giannis-rdx self-assigned this Aug 30, 2024

giannis-rdx requested review from micbakos-rdx and sergiupuhalschi-rdx August 30, 2024 12:55

giannis-rdx marked this pull request as ready for review September 1, 2024 14:40

sergiupuhalschi-rdx reviewed Sep 2, 2024

View reviewed changes

micbakos-rdx reviewed Sep 2, 2024

View reviewed changes

sergiupuhalschi-rdx approved these changes Sep 3, 2024

View reviewed changes

sergiupuhalschi-rdx reviewed Sep 3, 2024

View reviewed changes

app/src/main/java/com/babylon/wallet/android/presentation/dialogs/info/InfoDialog.kt Outdated Show resolved Hide resolved

sergiupuhalschi-rdx reviewed Sep 3, 2024

View reviewed changes

micbakos-rdx reviewed Sep 4, 2024

View reviewed changes

micbakos-rdx approved these changes Sep 4, 2024

View reviewed changes

giannis-rdx force-pushed the feature/ABW-1672-add-info-popup branch from d9f1ebd to 977fc05 Compare September 6, 2024 08:04

sergiupuhalschi-rdx approved these changes Sep 6, 2024

View reviewed changes

giannis-rdx force-pushed the feature/ABW-1672-add-info-popup branch from 8c33a55 to 835fbb1 Compare September 6, 2024 13:07

giannis-rdx added 15 commits September 6, 2024 17:34

added new icons for tokens and lsus

28255a7

added library for markdown

08e45f3

added GlossaryItem

1241b6f

added WarningText that replaces the InfoLink and can be reused for an…

c18952b

…y warnings

refactored and renamed InfoLink to InfoButton

5460eb3

added InfoDialog screen, nav, and viewmodel

c0c2780

added InfoDialog in assets tabs when empty

b06fc03

added InfoDialog in assets dialogs

af45a91

added InfoDialog in transaction review screen

5c2f635

added InfoDialog in ApprovedDapps screen and UI updates

53dcce3

added InfoDialog in CreatePersonaScreen

5257116

added InfoDialog in DepositGuaranteesScreen with few UI updates

ec3c55c

added InfoDialog in GatewaysScreen with few UI updates

f8edb90

updated NavigationHost for info dialog

25dd8d2

correct screen in GatewaysScreen

821fcfa

giannis-rdx added 16 commits September 6, 2024 17:34

styled the titles in InfoDialog

d6e97b9

more beautiful style

1b07152

much more beautiful style

63ea600

lib catalog for markdown

9fff523

minor

57cf714

fixed color in InfoButton

746c615

safe list

f6dc88e

fixed color

cfde721

updated proportion of dialog in the screen

05d746f

keep scroll state when external link is clicked

ba1cc0c

define color for links

594194a

fixed button width

34c4e27

added InfoButton for RadixConnect

33c758d

added InfoButton for badges in PresentingProofsContent

17587bb

added InfoButton for fees and involved accounts

2c9cb69

in TransactionReviewScreen

updated setting item string for advanced lock

5b97361

giannis-rdx force-pushed the feature/ABW-1672-add-info-popup branch from bbb9b7e to 5b97361 Compare September 6, 2024 14:34

giannis-rdx merged commit a05ffec into main Sep 7, 2024
8 of 9 checks passed

giannis-rdx deleted the feature/ABW-1672-add-info-popup branch September 7, 2024 13:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ABW-1672] Add info popup #1169

[ABW-1672] Add info popup #1169

giannis-rdx commented Aug 30, 2024 •

edited

Loading

sergiupuhalschi-rdx Sep 2, 2024

giannis-rdx Sep 2, 2024

sergiupuhalschi-rdx Sep 2, 2024

giannis-rdx Sep 3, 2024

sergiupuhalschi-rdx Sep 3, 2024

micbakos-rdx left a comment

micbakos-rdx Sep 2, 2024

giannis-rdx Sep 2, 2024

micbakos-rdx Sep 2, 2024

giannis-rdx Sep 2, 2024 •

edited

Loading

sergiupuhalschi-rdx left a comment

sergiupuhalschi-rdx Sep 3, 2024

micbakos-rdx Sep 4, 2024

sergiupuhalschi-rdx left a comment •

edited

Loading

sonarcloud bot commented Sep 6, 2024

		@@ -0,0 +1,34 @@
		package com.babylon.wallet.android.presentation.dialogs.info

		// the enums are defined the same way they are written in Strings ("glossaryAnchor" tags)

[ABW-1672] Add info popup #1169

[ABW-1672] Add info popup #1169

Conversation

giannis-rdx commented Aug 30, 2024 • edited Loading

Description

How to test

Video

PR submission checklist

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

micbakos-rdx left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

giannis-rdx Sep 2, 2024 • edited Loading

Choose a reason for hiding this comment

sergiupuhalschi-rdx left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sergiupuhalschi-rdx left a comment • edited Loading

Choose a reason for hiding this comment

sonarcloud bot commented Sep 6, 2024

Quality Gate failed

giannis-rdx commented Aug 30, 2024 •

edited

Loading

giannis-rdx Sep 2, 2024 •

edited

Loading

sergiupuhalschi-rdx left a comment •

edited

Loading