Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ABW-3669] Make uploadAuthKeyInteractionId nullable #1123

Merged
merged 1 commit into from
Aug 6, 2024
Merged

[ABW-3669] Make uploadAuthKeyInteractionId nullable #1123

merged 1 commit into from
Aug 6, 2024

Conversation

jakub-rdx
Copy link
Contributor

Description

  • when app is left on persona details when transaction comes in and is signed - app crashes on status dialog
    This is caused by listening for transaction status in that particular screen, and it's filter clause used lateinit variable that is not initialized

How to test

  1. Open app on persona details screen - the one where we have button to create auth key.
  2. Send any transaction from a dApp (sandbox/dashboard) and sign transaction
  3. App crashes before the fix

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@jakub-rdx jakub-rdx changed the title make uploadAuthKeyInteractionId nullable [ABW-3669] Make uploadAuthKeyInteractionId nullable Aug 5, 2024
sergiupuhalschi-rdx
sergiupuhalschi-rdx approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@sergiupuhalschi-rdx sergiupuhalschi-rdx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed!

@jakub-rdx jakub-rdx merged commit 1a71911 into main Aug 6, 2024
9 checks passed
@jakub-rdx jakub-rdx deleted the fix/ABW-3669-persona-detail-crash branch August 6, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giannis-rdx giannis-rdx giannis-rdx approved these changes

@micbakos-rdx micbakos-rdx micbakos-rdx approved these changes

@sergiupuhalschi-rdx sergiupuhalschi-rdx sergiupuhalschi-rdx approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jakub-rdx @giannis-rdx @micbakos-rdx @sergiupuhalschi-rdx