Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ABW-3664] Update insets on modal dialogs #1122

Merged
merged 4 commits into from
Aug 7, 2024

Conversation

jakub-rdx
Copy link
Contributor

Description

  • in some dialogs it looks like navigation bar insets are included twice, once by a default modal sheet dialog, and 2nd time from RadixBottomBar.

How to test

  1. See persona edit/persona create/gateway update and fee payer selection dialogs before the fix - bottom padding is too big compare to zeplin.
  2. Padding should be fine after the fix

@jakub-rdx jakub-rdx changed the title update insets on modal dialogs [ABW-3664] Update insets on modal dialogs Aug 5, 2024
@@ -33,7 +33,8 @@ fun DefaultModalSheetLayout(
sheetContent: @Composable () -> Unit,
showDragHandle: Boolean = true,
containerColor: Color = RadixTheme.colors.defaultBackground,
onDismissRequest: () -> Unit
windowInsets: WindowInsets = WindowInsets.systemBars,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

# Conflicts:
#	app/src/main/java/com/babylon/wallet/android/presentation/settings/preferences/gateways/GatewaysScreen.kt
Copy link
Contributor

@micbakos-rdx micbakos-rdx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

Copy link
Contributor

@sergiupuhalschi-rdx sergiupuhalschi-rdx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link

sonarcloud bot commented Aug 7, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 40%)

See analysis details on SonarCloud

@jakub-rdx jakub-rdx merged commit d9c6940 into main Aug 7, 2024
8 of 9 checks passed
@jakub-rdx jakub-rdx deleted the fix/ABW-3664-default-modal-insets branch August 7, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants