Fix crash when popping persona creation flow. #1121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakub-rdx
requested review from
giannis-rdx,
micbakos-rdx and
sergiupuhalschi-rdx
sergiupuhalschi-rdx
approved these changes
Aug 6, 2024
micbakos-rdx
approved these changes
Aug 6, 2024
| @@ -32,12 +33,14 @@ fun NavController.personaInfoScreen() { | |||
|
|
|||
| @Suppress("SwallowedException") | |||
There was a problem hiding this comment.
The suppress annotation can now be removed I think.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Crash hapened when user was on persona confirmation screen, popping screen to get back to the flow that started persona creation. Stacktrace says that current screen when crash occured is persona selection in dapp request handling flow. I was not able to reproduce, but it is clear from the report that it happened at
getBackStackEntry(ROUTE_CREATE_PERSONA)which throws if route is not on the backstack. Wrapped calls togetBackStackEntryin runCatching, and if we can't find root screen of the flow for some reason (entry == null), just pop current screen.How to test
adb shell am kill <package_name>and re-opened app from the Recent - still, was not able to crash the wallet.Any feedback on potential way of reproducing is welcomed