[ABW-3654] - Update screens navigation transitions #1120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiupuhalschi-rdx
requested review from
jakub-rdx,
giannis-rdx and
micbakos-rdx
|
giannis-rdx
approved these changes
Aug 5, 2024
micbakos-rdx
approved these changes
Aug 6, 2024
There was a problem hiding this comment.
Nice work. My only notes here are for these 2 screens
- EULA, does this need to be a slide up? I guess the reason it is a slide up is because it is an one-time popup?
- Account recovery in troubleshooting screen appears as a slide up, when the button displays an arrow to the right. Could you take a look?
jakub-rdx
approved these changes
Aug 6, 2024
Good catch. Fixed it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket
Description
This PR updates navigation transitions between screens.