-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dapp request handling logic to properly determine starting screen #1119
Conversation
…pp was already granted data fully/partially
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Take a look at the one time data request with persona data.
If I send a plain Persona data one time request the wallet doesn't open the request. ❌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works fine!
If none of the above are met, we have a request with either ongoing account and (or) persona data and we already granted data to such request in the past - ask for biometrics and complete request handling.
I'm not sure if we have to do anything about this or it works as expected but in this scenario I don't see the biometrics prompt, it goes straight to the success sheet.
You probably used requests without a proof, if there is a request with proof and signature needed, biometric prompt should appear |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅
…pecifies persona unknown to the dApp
Quality Gate failedFailed conditions |
Description
Re-arranged how we determine starting screen for request handling. Now it is as follow, when we hit one of those conditions, we don't examine the rest (when clause):
If none of the above are met, we have a request with either ongoing account and (or) persona data and we already granted data to such request in the past - ask for biometrics and complete request handling.
How to test
PR submission checklist