Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ABW-3647] Skip eula screen after it is accepted #1100

Merged
merged 4 commits into from
Jul 31, 2024

Conversation

jakub-rdx
Copy link
Contributor

@jakub-rdx jakub-rdx commented Jul 25, 2024

Description

Skip Eula screen after is is accepted.

How to test

  1. Verify that EULA screen is not shown when navigating back from subsequent screen, after eula accept button was used
  2. Verify that after accepting EULA and starting from onboarding screen - no eula is presented again

PR submission checklist

  • I have tested above scenarios and verified that they work

Copy link
Contributor

@micbakos-rdx micbakos-rdx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is a bug on the flow:

  1. Open wallet
  2. Accept eula
  3. Connect to google drive
  4. When in create account, press back
  5. Connect to google appears
  6. Press back again
  7. Click on creating a new wallet.
  8. After that the connect to google is never shown up again.

The requirement was that the google sign in should always appear. I would suggest opening the app prior to this fix and check how it behaves. I guess the eula screen was handling the sign out when pressing back since it was always on stack.

@jakub-rdx
Copy link
Contributor Author

I think there is a bug on the flow:

  1. Open wallet
  2. Accept eula
  3. Connect to google drive
  4. When in create account, press back
  5. Connect to google appears
  6. Press back again
  7. Click on creating a new wallet.
  8. After that the connect to google is never shown up again.

The requirement was that the google sign in should always appear. I would suggest opening the app prior to this fix and check how it behaves. I guess the eula screen was handling the sign out when pressing back since it was always on stack.

I though I ported the logic that EULA screen had, but will double check

@jakub-rdx
Copy link
Contributor Author

@micbakos-rdx your comment should be addressed now. Good catch

Copy link

sonarcloud bot commented Jul 31, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 40%)

See analysis details on SonarCloud

@jakub-rdx jakub-rdx merged commit b830d39 into main Jul 31, 2024
8 of 9 checks passed
@jakub-rdx jakub-rdx deleted the feature/ABW-3647-skip-eula-after-confirmed branch July 31, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants