-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ABW-3647] Skip eula screen after it is accepted #1100
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there is a bug on the flow:
- Open wallet
- Accept eula
- Connect to google drive
- When in create account, press back
- Connect to google appears
- Press back again
- Click on creating a new wallet.
- After that the connect to google is never shown up again.
The requirement was that the google sign in should always appear. I would suggest opening the app prior to this fix and check how it behaves. I guess the eula screen was handling the sign out when pressing back since it was always on stack.
I though I ported the logic that EULA screen had, but will double check |
@micbakos-rdx your comment should be addressed now. Good catch |
Quality Gate failedFailed conditions |
Description
Skip Eula screen after is is accepted.
How to test
PR submission checklist