[ABW-3545] Edit persona UI updates #1094
Conversation
jakub-rdx
requested review from
giannis-rdx,
micbakos-rdx and
sergiupuhalschi-rdx
| contentColor = RadixTheme.colors.gray1, | ||
| Scaffold(modifier = modifier, topBar = { | ||
| Column { | ||
| RadixCenteredTopAppBar( |
There was a problem hiding this comment.
Should it have an 'X' button instead of back? Maybe we should check with Aftab because the back icon doesn't make much sense on the bottom sheet here.
There was a problem hiding this comment.
Valid point. Waiting for the design for this, updated description
There was a problem hiding this comment.
In Zeplin there is a Cancel and Save buttons in the top app bar, but this is not reflected in the current PR. Also, currently, the screen has an X button but it takes full screen and appears animated from right to left.
There was a problem hiding this comment.
I don't think this design is accurate, we will most likely use icon on the upper left and Save(or Done) button at the bottom, so not far off from how it looks now
There was a problem hiding this comment.
Sounds good. I'll update my PR to reflect this as well.
There was a problem hiding this comment.
The vertical space between components looks smaller than in Zeplin. For example the space between the fields, especially between "Full Name" field and the "Name Order" or the space between the "Add a Field" button and the divider above it.
# Conflicts: # app/src/main/java/com/babylon/wallet/android/presentation/settings/personas/personaedit/PersonaEditScreen.kt # designsystem/src/main/java/com/babylon/wallet/android/designsystem/composable/RadixSecondaryButton.kt
"Full name" is a section label consisting of multiple input fields (given/family/nickname), so I guess it makes some sense and this is how it looks in zeplin |
|
Description
Note: still waiting for final design regarding X/back button and save button
How to test