Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ABW-3545] Edit persona UI updates #1094

Merged
merged 6 commits into from
Jul 31, 2024

Conversation

jakub-rdx
Copy link
Contributor

@jakub-rdx jakub-rdx commented Jul 24, 2024

Description

  • updates spacing on edit persona screen, moved delete icon to the right of the label
  • updated secondary button styl
  • updated add a field sheet, adding custom checkbox.

Note: still waiting for final design regarding X/back button and save button

How to test

  1. Verify Edit Persona/Add field sheet UI matches zeplin

contentColor = RadixTheme.colors.gray1,
Scaffold(modifier = modifier, topBar = {
Column {
RadixCenteredTopAppBar(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it have an 'X' button instead of back? Maybe we should check with Aftab because the back icon doesn't make much sense on the bottom sheet here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Valid point. Waiting for the design for this, updated description

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Zeplin there is a Cancel and Save buttons in the top app bar, but this is not reflected in the current PR. Also, currently, the screen has an X button but it takes full screen and appears animated from right to left.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this design is accurate, we will most likely use icon on the upper left and Save(or Done) button at the bottom, so not far off from how it looks now

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. I'll update my PR to reflect this as well.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The vertical space between components looks smaller than in Zeplin. For example the space between the fields, especially between "Full Name" field and the "Name Order" or the space between the "Add a Field" button and the divider above it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

Copy link
Contributor

@micbakos-rdx micbakos-rdx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor thing I am not sure about the full name title has more space from the Name Order Label, than the Phone number with the text field. Shouldn't those have the same padding?
Screenshot 2024-07-31 at 9 49 14 AM

# Conflicts:
#	app/src/main/java/com/babylon/wallet/android/presentation/settings/personas/personaedit/PersonaEditScreen.kt
#	designsystem/src/main/java/com/babylon/wallet/android/designsystem/composable/RadixSecondaryButton.kt
@jakub-rdx
Copy link
Contributor Author

One minor thing I am not sure about the full name title has more space from the Name Order Label, than the Phone number with the text field. Shouldn't those have the same padding? Screenshot 2024-07-31 at 9 49 14 AM

"Full name" is a section label consisting of multiple input fields (given/family/nickname), so I guess it makes some sense and this is how it looks in zeplin

@jakub-rdx jakub-rdx merged commit 8cf6b1d into main Jul 31, 2024
7 checks passed
@jakub-rdx jakub-rdx deleted the feature/ABW-3545-edit-persona-ui-updates branch July 31, 2024 14:57
Copy link

sonarcloud bot commented Jul 31, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 40%)

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants