Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ABW-2746] Refactor ROLA signing #1076

Merged
merged 27 commits into from
Aug 6, 2024
Merged

[ABW-2746] Refactor ROLA signing #1076

merged 27 commits into from
Aug 6, 2024

Commits on Aug 6, 2024

  1. deleted CollectSignersSignaturesUseCase and moved SignRequest to doma… 

    …in/model package
    @giannis-rdx
    giannis-rdx committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    c19222d View commit details
    Browse the repository at this point in the history

  2. deleted GetSigningEntitiesByFactorSourceUseCase

    @giannis-rdx
    giannis-rdx committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    cbb2d89 View commit details
    Browse the repository at this point in the history

  3. import SignRequest after moving to another package

    @giannis-rdx
    giannis-rdx committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    17acb96 View commit details
    Browse the repository at this point in the history

  4. replaced CollectSignersSignaturesUseCase with AccessFactorSourcesProx… 

    …y in ROLAClient
    @giannis-rdx
    giannis-rdx committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    3c6ba66 View commit details
    Browse the repository at this point in the history

  5. updated DAppAuthorizedLoginViewModel and DAppUnauthorizedLoginViewModel

    @giannis-rdx
    giannis-rdx committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    bcebfac View commit details
    Browse the repository at this point in the history

  6. updated all rola related screens

    @giannis-rdx
    giannis-rdx committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    ef61673 View commit details
    Browse the repository at this point in the history

  7. added a reminder

    @giannis-rdx
    giannis-rdx committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    9d09d8b View commit details
    Browse the repository at this point in the history

  8. added domain model EntityWithSignature

    @giannis-rdx
    giannis-rdx committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    1b51c5c View commit details
    Browse the repository at this point in the history

  9. replace result with EntityWithSignature in SignWithDeviceFactorSource… 

    …UseCase and

SignWithLedgerFactorSourceUseCase
    @giannis-rdx
    giannis-rdx committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    d20e6e9 View commit details
    Browse the repository at this point in the history

  10. created signing package under the domain package and moved the 

    signing related classes there because it's better
    @giannis-rdx
    giannis-rdx committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    65f90be View commit details
    Browse the repository at this point in the history

  11. refactored output of getSignatures to return a map of entities and th… 

    …eir signatures
    @giannis-rdx
    giannis-rdx committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    f8df802 View commit details
    Browse the repository at this point in the history

  12. refactored BuildDappResponseUseCase to first gathering signatures for… 

    … all entities and

then build the responses
    @giannis-rdx
    giannis-rdx committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    3cdf631 View commit details
    Browse the repository at this point in the history

  13. not needed check

    @giannis-rdx
    giannis-rdx committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    9d7f485 View commit details
    Browse the repository at this point in the history

  14. removed InteractionState

    @giannis-rdx
    giannis-rdx committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    fffaeea View commit details
    Browse the repository at this point in the history

  15. very minor in SignWithLedgerFactorSourceUseCase

    @giannis-rdx
    giannis-rdx committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    2040ef0 View commit details
    Browse the repository at this point in the history

  16. added SignType domain model that is used as input to get signatures

    @giannis-rdx
    giannis-rdx committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    130644f View commit details
    Browse the repository at this point in the history

  17. added SignType parameter

    @giannis-rdx
    giannis-rdx committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    368ee71 View commit details
    Browse the repository at this point in the history

  18. updated GetSignaturesDialog with proving ownership ui

    @giannis-rdx
    giannis-rdx committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    c9c4ca1 View commit details
    Browse the repository at this point in the history

  19. do not close the one time request screen when user cancels or rejects… 

    … signing
    @giannis-rdx
    giannis-rdx committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    3510e0b View commit details
    Browse the repository at this point in the history

  20. minor

    @giannis-rdx
    giannis-rdx committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    cca6a3e View commit details
    Browse the repository at this point in the history

  21. fixed missing case when updating account sharing

    @giannis-rdx
    giannis-rdx committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    f22331a View commit details
    Browse the repository at this point in the history

  22. fixed which accounts are available to sign

    @giannis-rdx
    giannis-rdx committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    170c5b1 View commit details
    Browse the repository at this point in the history

  23. fixed detekt issues

    @giannis-rdx
    giannis-rdx committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    fa7e786 View commit details
    Browse the repository at this point in the history

  24. disabled retry button when collecting signatures for device factor so… 

    …urce
    @giannis-rdx
    giannis-rdx committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    e365be0 View commit details
    Browse the repository at this point in the history

  25. slightly better name

    @giannis-rdx
    giannis-rdx committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    7a792e7 View commit details
    Browse the repository at this point in the history

  26. renamed status package to dialogs because it contains dialogs

    @giannis-rdx
    giannis-rdx committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    b50e679 View commit details
    Browse the repository at this point in the history

  27. removed obsolete code

    @giannis-rdx
    giannis-rdx committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    9ecb8e0 View commit details
    Browse the repository at this point in the history