[ABW-3532] Create persona ui adjustments #1059
Conversation
jakub-rdx
requested review from
sergiupuhalschi-rdx,
micbakos-rdx and
giannis-rdx
…stments # Conflicts: # app/src/main/java/com/babylon/wallet/android/presentation/settings/personas/createpersona/CreatePersonaInfoScreen.kt # app/src/main/java/com/babylon/wallet/android/presentation/settings/personas/createpersona/CreatePersonaScreen.kt
…stments # Conflicts: # designsystem/src/main/java/com/babylon/wallet/android/designsystem/composable/RadixPrimaryButton.kt # designsystem/src/main/java/com/babylon/wallet/android/designsystem/composable/RadixSecondaryButton.kt
There was a problem hiding this comment.
A few minor observations regarding CreatePersonaScreen:
- The top padding seems too big (between the screen top and the header) compared to zeplin
- The padding between the avatar placeholder and “Persona label” seems smaller compared to zeplin
- The padding between the divider and the “Some dApps may request..” text seems smaller compared to zeplin
- Persona Label input hint should have gray color
- It would be nice to set sentences capitalization to the label input
...ystem/src/main/java/com/babylon/wallet/android/designsystem/composable/RadixPrimaryButton.kt
Outdated
Show resolved
Hide resolved
…stments # Conflicts: # designsystem/src/main/java/com/babylon/wallet/android/designsystem/composable/RadixSecondaryButton.kt
There was a problem hiding this comment.
The persona label currently supports multiple lines, but it should be single line and with Done ime action. Also maybe it should have KeyboardCapitalization.Words since it's a name? Sorry for mentioning "Sentences" in the previous review.
There was a problem hiding this comment.
@jakub-rdx don't forget about this. IMHO this will bring much value with a little effort.
|
Besides on the points @sergiupuhalschi-rdx mentioned I also noticed that in the confirmation screen the bottom button has bigger paddings than than the button in the creation flow. Also should this button be a bottom bar and use a divider? Take a look at the video: selection.webm |
|
On Congratulations screen the CTA should have a "Continue to" prefix |
already updated |
updated with RadixBotomBar |
…stments # Conflicts: # app/src/main/java/com/babylon/wallet/android/presentation/settings/personas/createpersona/CreatePersonaScreen.kt # designsystem/src/main/java/com/babylon/wallet/android/designsystem/composable/RadixSecondaryButton.kt
jakub-rdx
deleted the
feature/ABW-3532-create-persona-flow-ui-adjustments
branch
|
Description
Screenshot