[ABW-3435] - Display home cards carousel #1033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiupuhalschi-rdx
requested review from
jakub-rdx,
micbakos-rdx and
giannis-rdx
There was a problem hiding this comment.
The carousel works as it is described. Couple of questions.
- I realised that we inform sargon to check what cards to show with the
walletCreatedcallback. If so we lose one case. Now that we remove the hint to link to a new connector, what should happen to existing users that never connected to CE and update to this version? They will never see the card to connect to CE. Is this expected? - The Continue on dApp in browser card, does nothing on click, you can only close it via the X button. I guess this is expected?
| private fun bootstrapHomeCardsManager() { | ||
| scope.launch { | ||
| runCatching { homeCardsManager.bootstrap() } | ||
| .onFailure { Timber.d("HomeCardsManager init error: ${it.message}") } |
There was a problem hiding this comment.
Maybe use w instead of d?
|
|
||
| override suspend fun cardDismissed(card: HomeCard) { | ||
| runCatching { homeCardsManager.cardDismissed(card) } | ||
| .onFailure { Timber.d("Failed to dismiss home card. Error: $it") } |
|
|
||
| val isCloudBackupEnabled = args.requestSource == CreateAccountRequestSource.FirstTimeWithCloudBackupEnabled | ||
| changeBackupSettingUseCase(isChecked = isCloudBackupEnabled) | ||
| } | ||
| } | ||
|
|
||
| private suspend fun initHomeCards() { | ||
| runCatching { homeCardsManager.walletCreated() } | ||
| .onFailure { Timber.d("Failed to notify HomeCardsManager about wallet creation. Error: $it") } |
| applicationScope.launch { | ||
| withContext(defaultDispatcher) { | ||
| runCatching { homeCardsManager.deferredDeepLinkReceived(value) } | ||
| .onFailure { Timber.d("Failed to notify HomeCardsManager about deep link receiving. Error: $it") } |
|
micbakos-rdx
approved these changes
Jul 10, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds home cards carousel functionality.
How to test
The users from organic app installs use-case: