Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pre-select single persona when none selected #1029

Merged
merged 1 commit into from
Jul 4, 2024
Merged

Pre-select single persona when none selected #1029

merged 1 commit into from
Jul 4, 2024

Conversation

micbakos-rdx
Copy link
Contributor

Description

  • When there is only one persona available, preselect it.
  • When there are more than one personas or one persona was already authorised for a dApp continue the same logic as before

How to test

  1. Create one persona. Subsequent logins with dApps have this persona pre-selected.
  2. Create multiple personas. Subsequent logins have nothing preselected, except if one persona was authorised in the past. If so that persona in ordered first, preselected and displays the last used timestamp

@micbakos-rdx micbakos-rdx self-assigned this Jul 4, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@micbakos-rdx micbakos-rdx merged commit f171dfd into main Jul 4, 2024
9 checks passed
@micbakos-rdx micbakos-rdx deleted the feature/ABW-3478-preselect-persona branch July 4, 2024 09:05
@micbakos-rdx micbakos-rdx mentioned this pull request Jul 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giannis-rdx giannis-rdx giannis-rdx approved these changes

@sergiupuhalschi-rdx sergiupuhalschi-rdx sergiupuhalschi-rdx approved these changes

Assignees

@micbakos-rdx micbakos-rdx

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@micbakos-rdx @giannis-rdx @sergiupuhalschi-rdx