Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure TransactionReviewViewModel #1028

Merged
merged 2 commits into from
Jul 3, 2024

Conversation

giannis-rdx
Copy link
Contributor

Description

Move model classes under the presentation/transaction/model/ package.

@@ -34,3 +35,9 @@ object FeesResolver {
}
}
}

private fun List<AccountWithTransferableResources>.guaranteesCount(): Int = map { accountWithTransferableResources ->
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is private now

@@ -114,6 +114,10 @@ fun DepositAccountContent(
}
}

private fun List<AccountWithTransferableResources>.hasCustomizableGuarantees() = any { accountWithTransferableResources ->
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

private too

Copy link

sonarcloud bot commented Jul 3, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 40%)

See analysis details on SonarCloud

@giannis-rdx giannis-rdx merged commit 4eb961f into main Jul 3, 2024
8 of 9 checks passed
@giannis-rdx giannis-rdx deleted the task/restructure-transactionreviewviewmodel branch July 3, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants