Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatic refresh #1026

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Automatic refresh #1026

wants to merge 10 commits into from

Conversation

micbakos-rdx
Copy link
Contributor

Description

  • The wallet screen refreshes the assets every 5 minutes and the account screen every 1 minute
  • The "refresh timer" starts counting from the last time a previous refresh occurred. Meaning that if the user does a manual refresh meanwhile then the timer restarts.
  • Errors are not shown when an automatic refresh occurs.
  • Substantial changes to the WalletViewModel regarding the structure of state and how it is represented. More detailed types for refresh and price state exist and give more flexibility to preserve state and convey it to the user.

How to test

  1. Open wallet from scratch
  2. Reopen wallet
  3. Play around with refresh
  4. Do the same with account screen

@micbakos-rdx micbakos-rdx self-assigned this Jul 2, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 3, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 40%)

See analysis details on SonarCloud

sergiupuhalschi-rdx
sergiupuhalschi-rdx approved these changes Jul 4, 2024
View reviewed changes
Copy link
Contributor

@sergiupuhalschi-rdx sergiupuhalschi-rdx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergiupuhalschi-rdx sergiupuhalschi-rdx sergiupuhalschi-rdx approved these changes

@jakub-rdx jakub-rdx Awaiting requested review from jakub-rdx

@giannis-rdx giannis-rdx Awaiting requested review from giannis-rdx

At least 2 approving reviews are required to merge this pull request.

Assignees

@micbakos-rdx micbakos-rdx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@micbakos-rdx @sergiupuhalschi-rdx