Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix request handled on rejection at Login screen #1024

Merged
merged 1 commit into from
Jul 2, 2024
Merged

Fix request handled on rejection at Login screen #1024

merged 1 commit into from
Jul 2, 2024

Conversation

giannis-rdx
Copy link
Contributor

@giannis-rdx giannis-rdx commented Jul 2, 2024 •
edited
Loading

Description

This PR solves the following bug:

  1. launch wallet
  2. connect to a desktop dapp, e.g. https://dev-sandbox.rdx-works-main.extratools.works/
  3. send a transaction request through webrtc fromt the above dapp - leave request on the screen
  4. send a "Update Account Sharing" through webrtc fromt the above dapp
  5. send a mobile connect request from RQ
  6. send a mobile connect request from gumball
  7. now you have a total of 4 requests in the queue
  8. back to the wallet start rejecting requests one by one

At this point you won't get on the screen the last 2 (mobile) requests and you will dismiss only the first two.

@giannis-rdx giannis-rdx self-assigned this Jul 2, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sergiupuhalschi-rdx
sergiupuhalschi-rdx approved these changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@sergiupuhalschi-rdx sergiupuhalschi-rdx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine!

@giannis-rdx giannis-rdx merged commit 4b75b67 into main Jul 2, 2024
9 checks passed
@giannis-rdx giannis-rdx deleted the fix/proper-screen-reject-when-authorized-login branch July 2, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micbakos-rdx micbakos-rdx micbakos-rdx approved these changes

@sergiupuhalschi-rdx sergiupuhalschi-rdx sergiupuhalschi-rdx approved these changes

@GhenadieVP GhenadieVP Awaiting requested review from GhenadieVP

@jakub-rdx jakub-rdx Awaiting requested review from jakub-rdx

Assignees

@giannis-rdx giannis-rdx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@giannis-rdx @micbakos-rdx @sergiupuhalschi-rdx