Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable priority queue for mobile requests #1023

Merged
merged 4 commits into from
Jul 1, 2024

Conversation

giannis-rdx
Copy link
Contributor

No description provided.

Copy link
Contributor

@sergiupuhalschi-rdx sergiupuhalschi-rdx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it seems to be working fine!

} else {
incomingRequestRepository.add(request)
}
// if (request.isMobileConnectRequest) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A comment would help in case we don't come back to this promptly.

Copy link

sonarcloud bot commented Jul 1, 2024

Copy link
Contributor

@GhenadieVP GhenadieVP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@@ -151,7 +151,7 @@ class IncomingRequestRepositoryImpl @Inject constructor(
// Put high priority item below any internal request and mobile connect requests
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment should maybe updated too.

@micbakos-rdx micbakos-rdx merged commit dedb23a into main Jul 1, 2024
9 checks passed
@micbakos-rdx micbakos-rdx deleted the task/revert-priorioty-queue-for-mobile-requests branch July 1, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants