Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix derive public key dialog when user dismiss #1020

Merged
merged 2 commits into from
Jul 1, 2024

Conversation

giannis-rdx
Copy link
Contributor

@giannis-rdx giannis-rdx commented Jun 30, 2024

Description

This PR fixes a bug where the user dismiss the bottom sheet dialog when creating a new account.

How to test

This is very hard to reproduce.

Test 1

  1. With an existing wallet click on "Create a New Account" at wallet screen
  2. At the "Create New Account" screen type an account name and click "Continue"
  3. Dismiss the biometric prompt
  4. Click on the "X" button of the "Creating Account" bottomsheet dialog
  5. Remain at the "Create New Account" screen and select "Create with Ledger..."
  6. Add a NEW ledger device
  7. Once adding ledger flow is done select the new ledger and proceed

At this point the wallet returns again back to "Create New Account" screen.

Test 2

  1. Fresh install wallet
  2. At "Create First Account" screen give a name and select with ledger
  3. Click continue and authenticate
  4. At "Choose Ledger Device" navigate back
  5. And then click again "continue" at the "Create First Account" screen
  6. Proceed with the flow to add a ledger
  7. Once ledger is added and selected

At this point you will see (very instant) the bottomshet "Creating Account" dialog twice.

❗ In addition this crash might be related to this fix.

PR submission checklist

  • I have tested account creation with several scenarios when user dismiss

Copy link

sonarcloud bot commented Jun 30, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 40%)
3.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link
Contributor

@micbakos-rdx micbakos-rdx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got to reproduce it!

@giannis-rdx giannis-rdx merged commit 8f5ed05 into main Jul 1, 2024
8 of 9 checks passed
@giannis-rdx giannis-rdx deleted the fix/derive-piblic-key-dialog-when-dismissing branch July 1, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants