Show all metadata and mark the locked ones with lock icon #1010

micbakos-rdx · 2024-06-26T11:35:06Z

Description

Asset details dialog got upgraded to support, non standard metadata. The metadata are received from Gateway paginated.

UI

We display the non standard metadata in the same manner we display the NF Data. Using the MetadataView. This view got 2 changes:
1. PublicKeys and PublicKeyHashes display in 1 line with ... on the end and can be copied.
2. The lock icon is introduced for metadata that have is_locked = true
3. The previously known as AssetMetadataRow is renamed to MetadataView and became modular to either accept metadata or primitive values (used for standard metadata)
4. The non standard metadata will be shown at the bottom with a divider.

Also the claim button in the NFT dialog has been updated.

Note

~~We need to clarify on UI how name, symbol and icon_url will display their locked property when they are locked.~~
The decision was to put the lock icon only in the non standard metadata.

How to test

Here is a manifest that creates some NFT collections with multiple metadata on the collection resource.
many-metadata.txt

Videos

meta.webm

PR submission checklist

I have tested account to account transfer flow and have confirmed that it works

jakub-rdx · 2024-06-27T11:13:55Z

...ava/com/babylon/wallet/android/data/gateway/extensions/EntityMetadataCollectionExtensions.kt

@@ -208,16 +242,19 @@ fun EntityMetadataItem.toMetadata(): Metadata? = when (val typed = value.typed)
 Metadata.Primitive(
 key = key,
 value = "${it.resourceAddress}:${it.nonFungibleId}",


shouldn't here we also use NonFungibleGlobalId as a type, same as for MetadataNonFungibleGlobalIdValue above?

Oops missed that.

jakub-rdx · 2024-06-27T11:19:29Z

...rc/main/java/com/babylon/wallet/android/data/repository/cache/database/ProvidedConverters.kt

@@ -37,23 +109,23 @@ class StateDatabaseConverters {
 // Behaviours
 @TypeConverter
 fun stringToBehaviours(string: String?): BehavioursColumn? {
- return string?.let { BehavioursColumn(behaviours = json.decodeFromString(string)) }
+ return string?.let { json.decodeFromString(string) }


maybe we should use same json as we use for gateway models serialization?

No it is different, this is how the column is serialized into a json string. Room stores metadata in a custom type called MetadataColumn which uses this serialisation logic inside. Also the Metadata type we have defined is a domain model and not a GW one.

jakub-rdx · 2024-06-27T11:21:22Z

app/src/main/java/com/babylon/wallet/android/data/repository/cache/database/ResourceEntity.kt

 details: StateEntityDetailsResponseItemDetails?,
 type: ResourceEntityType,
 synced: Instant
 ): ResourceEntity {
- val metadata = metadataCollection?.toMetadata().orEmpty()
+ val metadataColumn = if (implicitMetadata != null) {


what is the difference between explicit/implicit metadata?

Explicit metadata are the ones we request when we communicate with GW and GW ensures that we will receive them. Also known as standard metadata. For example a resource may have defined 150 metadata. If you do a simple entity details request, on the first response we will only receive the first page of them (100) and we need to paginate them in order to get the other 50.

Although we need to somehow make sure that some metadata will be received since are crucial to rendering the UI without the need of pagination, like name, symbol, description, icon_url....

So for these requests you will see that we put ExplicitMetadataKey.forAssets in order to retrieve in the explicit_metadata field these crucial ones we need for ui.

When the user navigates to asset details, we can also display the rest of the metadata (besides the explicit ones). Decided to call them implicit. If we know that there is a page to be paginated, this is the time we do it.

jakub-rdx · 2024-06-27T11:47:33Z

app/src/main/java/com/babylon/wallet/android/presentation/account/composable/MetadataView.kt

 ) {
- KeyView()
+ MetadataKeyView(key = key, isLocked = isLocked)


Maybe it is worth to allocate some max width to the metadata key, I noticed that for some metadata names, long ones, there is not much space left for the value. When increasing font size a bit in the system (from already quite big default setting on samsung), value is pushed out of the screen

Yes I saw that too. It is a bit tricky this one. Since we need to see if both key and value cannot be squeezed into a single row. If I added a max width to the key, and a value was too small, you would see a key being separated in two lines while there would clearly be way for the value in the same row.

@jakub-rdx I pushed a commit ditching the Row and replacing it with constraint layout. It works better know. If a key has more than 30 chars it divides the space a little better.

jakub-rdx · 2024-06-27T11:54:56Z

app/src/main/java/com/babylon/wallet/android/presentation/account/composable/MetadataView.kt

+ text = metadata.value,
+ style = style,
+ color = color,
+ textAlign = if (isRenderedInNewLine) TextAlign.Start else TextAlign.End,


minor: maybe we can declare textAlign before when claus once and use it in all cases?

This is not applicable in all cases though. There are cases where we align start only.

jakub-rdx

Works good, great work in generalizing metadata views! Only one comment about metadata key width

giannis-rdx

tested and it seems to be working fine 👌🏽

giannis-rdx · 2024-06-27T12:24:25Z

app/src/main/java/com/babylon/wallet/android/data/repository/state/AccountsStateCache.kt

@@ -234,57 +233,47 @@ class AccountsStateCache @Inject constructor(
 result
 }

- private fun Flow<MutableMap<AccountAddress, AccountCachedData>>.compileAccountAddressAssets(): Flow<List<AccountAddressWithAssets>> =


I think we should better keep the return type, unless it is extremely obvious what it returns.

it's so much easier to read the code

Yes I did that but detekt complains

Yes I did that but detekt complains

What? 😮

giannis-rdx · 2024-06-27T12:28:44Z

app/src/main/java/com/babylon/wallet/android/domain/usecases/assets/GetLSUDetailsUseCase.kt

this and the other one is unused, right?
good that you removed them.

sergiupuhalschi-rdx

Tested and it works fine

…psis at the end

…alIdArrayValue

sonarcloud · 2024-06-28T10:02:44Z

Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 40%)

See analysis details on SonarCloud

micbakos-rdx added the Do not merge label Jun 26, 2024

micbakos-rdx requested review from jakub-rdx, giannis-rdx and sergiupuhalschi-rdx June 26, 2024 11:35

micbakos-rdx self-assigned this Jun 26, 2024

micbakos-rdx force-pushed the feature/all-metadata branch 3 times, most recently from 07d4b97 to 225bab9 Compare June 27, 2024 10:07

micbakos-rdx removed the Do not merge label Jun 27, 2024

jakub-rdx reviewed Jun 27, 2024

View reviewed changes

jakub-rdx approved these changes Jun 27, 2024

View reviewed changes

giannis-rdx approved these changes Jun 27, 2024

View reviewed changes

sergiupuhalschi-rdx approved these changes Jun 28, 2024

View reviewed changes

micbakos-rdx added 13 commits June 28, 2024 12:52

Add next cursor information on metadata column

d35af95

Request all pages of metadata for asset details dialog

301a188

Show non standard metadata in asset details dialog sheet

9e51481

Improve how global id is constructed from string metadata

d50a0e9

Replace AssetMetadataRow with modular MetadataView

514a257

Add lock information in tags section

3cc5e0e

Create a specific section for description

ab62f3e

Public keys and hashes are show single line with copy action and elli…

d932cc2

…psis at the end

Inline url metadata icon

13d1a6f

Fix test issues

480ebd4

Put back info url

72be154

Add more info url

76a8dee

Unify usage of LinkText

2a350f2

micbakos-rdx added 5 commits June 28, 2024 12:52

Put non standard metadata at the end of the sheet

0195e7f

Implement redesigned claim nft

9f49a92

Create global id string using sargon also for MetadataNonFungibleGlob…

8454eaa

…alIdArrayValue

Make metadata keys adapt when they are shown in row form

696baae

Update strings

11bb869

micbakos-rdx force-pushed the feature/all-metadata branch from 1f79860 to 11bb869 Compare June 28, 2024 09:54

micbakos-rdx merged commit f72bf3d into main Jun 28, 2024
8 of 9 checks passed

micbakos-rdx deleted the feature/all-metadata branch June 28, 2024 13:33

micbakos-rdx mentioned this pull request Jun 28, 2024

Revert "Show all metadata and mark the locked ones with lock icon" #1018

Merged

micbakos-rdx restored the feature/all-metadata branch June 28, 2024 14:30

micbakos-rdx mentioned this pull request Jul 1, 2024

All metadata #1022

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Show all metadata and mark the locked ones with lock icon #1010

Show all metadata and mark the locked ones with lock icon #1010

micbakos-rdx commented Jun 26, 2024 •

edited

Loading

jakub-rdx Jun 27, 2024

micbakos-rdx Jun 28, 2024

jakub-rdx Jun 27, 2024

micbakos-rdx Jun 28, 2024

jakub-rdx Jun 27, 2024

micbakos-rdx Jun 28, 2024

jakub-rdx Jun 27, 2024

micbakos-rdx Jun 28, 2024

micbakos-rdx Jun 28, 2024

jakub-rdx Jun 27, 2024

micbakos-rdx Jun 28, 2024

jakub-rdx left a comment

giannis-rdx left a comment

giannis-rdx Jun 27, 2024

giannis-rdx Jun 27, 2024

micbakos-rdx Jun 28, 2024

giannis-rdx Jun 28, 2024

giannis-rdx Jun 27, 2024

sergiupuhalschi-rdx left a comment

sonarcloud bot commented Jun 28, 2024

Show all metadata and mark the locked ones with lock icon #1010

Show all metadata and mark the locked ones with lock icon #1010

Conversation

micbakos-rdx commented Jun 26, 2024 • edited Loading

Description

UI

How to test

Videos

PR submission checklist

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jakub-rdx left a comment

Choose a reason for hiding this comment

giannis-rdx left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sergiupuhalschi-rdx left a comment

Choose a reason for hiding this comment

sonarcloud bot commented Jun 28, 2024

Quality Gate failed

micbakos-rdx commented Jun 26, 2024 •

edited

Loading