Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send exception logs to email for users that experience incompatible profile #1000

Merged
merged 3 commits into from
Jun 20, 2024
Merged

Send exception logs to email for users that experience incompatible profile #1000

merged 3 commits into from
Jun 20, 2024

Conversation

micbakos-rdx
Copy link
Contributor

  • Updated sargon dependency, which exposes serde error message
  • Add the ability to send the error message to support so we can figure out what the problem is for each user affected.
  • In the email body, the following are provided
    • Device version
    • App version
    • If the error is of type CommonException we display the code for that
      • If it is specifically CommoneException.FailedToDeserializeJsonToValue we also provide the message and a stacktrace.
    • If the exception any other one, then we paste the message and the stacktrace

Screenshot

@micbakos-rdx micbakos-rdx self-assigned this Jun 19, 2024
sergiupuhalschi-rdx
sergiupuhalschi-rdx approved these changes Jun 19, 2024
View reviewed changes
core/src/main/java/rdx/works/core/sargon/NetworkIdExtensions.kt Outdated
@@ -1,6 +1,6 @@
package rdx.works.core.sargon

import com.radixdlt.sargon.CommonException
import com.radixdlt.sargon. CommonException
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The import is broken here

giannis-rdx
giannis-rdx approved these changes Jun 20, 2024
View reviewed changes
Copy link
Contributor

@giannis-rdx giannis-rdx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌🏽

@micbakos-rdx
Copy link
Contributor Author

I am dragging this PR a bit further to attach the newer version of Sargon from radixdlt/sargon#171

@micbakos-rdx micbakos-rdx merged commit 7581c52 into main Jun 20, 2024
6 checks passed
@micbakos-rdx micbakos-rdx deleted the send-error-message-incompatible-profile branch June 20, 2024 10:12
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 20, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakub-rdx jakub-rdx jakub-rdx approved these changes

@giannis-rdx giannis-rdx giannis-rdx approved these changes

@sergiupuhalschi-rdx sergiupuhalschi-rdx sergiupuhalschi-rdx approved these changes

@GhenadieVP GhenadieVP Awaiting requested review from GhenadieVP

Assignees

@micbakos-rdx micbakos-rdx

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@micbakos-rdx @jakub-rdx @giannis-rdx @sergiupuhalschi-rdx