pr changes

app/src/main/java/com/babylon/wallet/android/data/gateway/extensions/StateEntityDetailsApiHelper.kt

@@ -86,7 +86,7 @@ suspend fun StateApi.fetchAccountGatewayDetails(
 suspend fun StateApi.fetchPools(
     poolAddresses: Set<String>,
     stateVersion: Long
-): List<FetchPoolsResult> {
+): List<PoolsResponse> {
     if (poolAddresses.isEmpty()) return emptyList()
 
     val poolDetails = mutableMapOf<String, StateEntityDetailsResponseItem>()
@@ -107,7 +107,7 @@ suspend fun StateApi.fetchPools(
         }
     }
 
-    val result = mutableListOf<FetchPoolsResult>()
+    val result = mutableListOf<PoolsResponse>()
     paginateDetails(
         addresses = resourceToPoolComponentAssociation.keys, // Request details for resources
         metadataKeys = ExplicitMetadataKey.forAssets,
@@ -116,15 +116,15 @@ suspend fun StateApi.fetchPools(
         resourcesDetails.items.forEach { resourceDetails ->
             val poolAddress = resourceToPoolComponentAssociation[resourceDetails.address]
             poolDetails[poolAddress]?.let { poolDetails ->
-                result.add(FetchPoolsResult(poolDetails, resourceDetails, poolWithResources[poolAddress].orEmpty()))
+                result.add(PoolsResponse(poolDetails, resourceDetails, poolWithResources[poolAddress].orEmpty()))
             }
         }
     }
 
     return result
 }
 
-data class FetchPoolsResult(
+data class PoolsResponse(
     val poolDetails: StateEntityDetailsResponseItem,
     val poolUnitDetails: StateEntityDetailsResponseItem,
     val poolResourcesDetails: List<FungibleResourcesCollectionItem>

app/src/main/java/com/babylon/wallet/android/data/repository/cache/database/PoolEntity.kt

@@ -5,7 +5,7 @@ import androidx.room.Entity
 import androidx.room.ForeignKey
 import androidx.room.Index
 import androidx.room.PrimaryKey
-import com.babylon.wallet.android.data.gateway.extensions.FetchPoolsResult
+import com.babylon.wallet.android.data.gateway.extensions.PoolsResponse
 import com.babylon.wallet.android.data.gateway.extensions.toMetadata
 import com.babylon.wallet.android.data.gateway.generated.models.StateEntityDetailsResponseItem
 import com.babylon.wallet.android.data.repository.cache.database.PoolResourceJoin.Companion.asPoolResourceJoin
@@ -34,7 +34,7 @@ data class PoolEntity(
 
     companion object {
         @Suppress("UnsafeCallOnNullableType")
-        fun List<FetchPoolsResult>.asPoolsResourcesJoin(
+        fun List<PoolsResponse>.asPoolsResourcesJoin(
             syncInfo: SyncInfo
         ): List<PoolWithResourcesJoinResult> =
             mapNotNull { fetchedPoolDetails ->

app/src/main/java/com/babylon/wallet/android/domain/model/Transferable.kt

@@ -37,7 +37,10 @@ sealed interface Transferable {
                             instructionIndex = predicted.instructionIndex
                         )
 
-                        is TransferableResource.StakeClaimNft -> null
+                        is TransferableResource.StakeClaimNft -> GuaranteeAssertion.ForNFT(
+                            instructionIndex = predicted.instructionIndex
+                        )
+
                         is TransferableResource.PoolUnitAmount -> GuaranteeAssertion.ForAmount(
                             amount = transferable.amount * predicted.guaranteeOffset.toBigDecimal(),
                             instructionIndex = predicted.instructionIndex

app/src/main/java/com/babylon/wallet/android/domain/usecases/assets/GetPoolUnitDetailsUseCase.kt

@@ -23,7 +23,7 @@ class GetPoolUnitDetailsUseCase @Inject constructor(
         val poolAddress = poolResource.poolAddress ?: return@then runCatching {
             error("Resource $resourceAddress is not associated with a pool")
         }
-        stateRepository.getPools(setOf(poolAddress)).map {
+        stateRepository.getPools(setOf(poolAddress)).mapCatching {
             PoolUnit(
                 stake = poolResource,
                 pool = it.first()

app/src/main/java/com/babylon/wallet/android/presentation/transaction/analysis/PoolContributionAnalysis.kt

@@ -23,7 +23,7 @@ suspend fun DetailedManifestClass.PoolContribution.resolve(
     getProfileUseCase: GetProfileUseCase,
     resources: List<Resource>,
     involvedPools: List<Pool>
-): PreviewType {
+): PreviewType.Transfer.Pool {
     val defaultDepositGuarantees = getProfileUseCase.invoke().first().appPreferences.transaction.defaultDepositGuarantee
     val accountsWithdrawnFrom = executionSummary.accountWithdraws.keys
     val ownedAccountsWithdrawnFrom = getProfileUseCase.accountsOnCurrentNetwork().filter {

app/src/main/java/com/babylon/wallet/android/presentation/transaction/analysis/PoolRedemptionAnalysis.kt

@@ -20,7 +20,7 @@ suspend fun DetailedManifestClass.PoolRedemption.resolve(
     getProfileUseCase: GetProfileUseCase,
     resources: List<Resource>,
     involvedPools: List<Pool>
-): PreviewType {
+): PreviewType.Transfer.Pool {
     val accountsWithdrawnFrom = executionSummary.accountDeposits.keys
     val ownedAccountsWithdrawnFrom = getProfileUseCase.accountsOnCurrentNetwork().filter {
         accountsWithdrawnFrom.contains(it.address)

app/src/main/java/com/babylon/wallet/android/presentation/transaction/analysis/StakeAnalysis.kt

@@ -18,7 +18,7 @@ suspend fun DetailedManifestClass.ValidatorStake.resolve(
     getProfileUseCase: GetProfileUseCase,
     resources: List<Resource>,
     involvedValidators: List<ValidatorDetail>
-): PreviewType {
+): PreviewType.Transfer.Staking {
     val fromAccounts = extractWithdrawals(executionSummary, getProfileUseCase, resources)
     val toAccounts = extractDeposits(
         executionSummary = executionSummary,

app/src/main/java/com/babylon/wallet/android/presentation/transaction/analysis/StakeClaimAnalysis.kt

@@ -20,7 +20,7 @@ suspend fun DetailedManifestClass.ValidatorClaim.resolve(
     resources: List<Resource>,
     involvedValidators: List<ValidatorDetail>,
     stakeClaimsNfts: List<Resource.NonFungibleResource.Item>
-): PreviewType {
+): PreviewType.Transfer.Staking {
     val toAccounts = extractDeposits(executionSummary, getProfileUseCase, resources)
     val fromAccounts = extractWithdrawals(
         executionSummary = executionSummary,

app/src/main/java/com/babylon/wallet/android/presentation/transaction/analysis/TransactionAnalysisDelegate.kt

@@ -68,9 +68,7 @@ class TransactionAnalysisDelegate @Inject constructor(
             manifestSummary = manifestSummary,
             ephemeralNotaryPrivateKey = _state.value.ephemeralNotaryPrivateKey
         )
-        manifest.toPrettyString().let { prettyString ->
-            logger.d(prettyString)
-        }
+        logger.d(manifest.toPrettyString())
         return transactionClient.getTransactionPreview(
             manifest = manifest,
             notaryAndSigners = notaryAndSigners

app/src/main/java/com/babylon/wallet/android/presentation/transaction/analysis/UnstakeAnalysis.kt

@@ -16,7 +16,7 @@ suspend fun DetailedManifestClass.ValidatorUnstake.resolve(
     getProfileUseCase: GetProfileUseCase,
     resources: List<Resource>,
     involvedValidators: List<ValidatorDetail>
-): PreviewType {
+): PreviewType.Transfer.Staking {
     val fromAccounts = extractWithdrawals(executionSummary, getProfileUseCase, resources, involvedValidators)
     val toAccounts = extractDeposits(executionSummary, getProfileUseCase, resources, involvedValidators)
     val validatorAddressesSet = validatorAddresses.map { it.addressString() }.toSet()