Visually render the Progress max
prop
#492
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for providing radix themes, it's been a joy working with this package. This is my first PR here, so please let me know if I'm missing anything.
Description
When rendering the Progress component, calculate the transform scaleX of the Progress.Indicator using the
max
prop supplied by the user.The
max
prop is documented for the Progress primitive component and is used when determining thearia-valuemax
andaria-valuetext
attributes for the Progress div.Testing steps
I'm using this sample app to test the change
Screen.Recording.2024-05-08.at.13.04.30.mov
Relates issues / PRs
None seen.