Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parameter for minimal and maximal altitudes #15

Merged
merged 2 commits into from
Dec 31, 2024
Merged

Conversation

tgross03
Copy link
Collaborator

Added min_alt and max_alt parameters to be able to adapt to simulation or telescope altitude restrictions.

@tgross03 tgross03 requested a review from aknierim December 20, 2024 18:23
@tgross03 tgross03 linked an issue Dec 20, 2024 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 33.33333% with 8 lines in your changes missing coverage. Please review.

Project coverage is 55.14%. Comparing base (b65e290) to head (16da50b).

Files with missing lines Patch % Lines
radiotools/visibility/visibility.py 33.33% 3 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #15      +/-   ##
==========================================
- Coverage   55.55%   55.14%   -0.41%     
==========================================
  Files          14       14              
  Lines         594      602       +8     
  Branches       60       63       +3     
==========================================
+ Hits          330      332       +2     
- Misses        253      256       +3     
- Partials       11       14       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aknierim
Copy link
Member

Approved, but could you also add tests?

@tgross03
Copy link
Collaborator Author

Approved, but could you also add tests?

Yeah, should be no problem. Will be on my to-do list.

@tgross03 tgross03 merged commit 5623781 into main Dec 31, 2024
7 checks passed
@tgross03 tgross03 deleted the vis_alt_restriction branch December 31, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add optional parameter for Alt restriction
3 participants