Skip to content

Add Arabic locale #571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

randa-11295
Copy link
Contributor

This branch adds Arabic language support to the project, including localisation and translations. RTL adjustments will be handled in a separate step if necessary

@randa-11295 randa-11295 requested a review from m-mohr as a code owner February 22, 2025 16:06
Copy link
Collaborator

@m-mohr m-mohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much! This is an awesome addition to STAC Browser.

I've left some comments for your consideration.

What's your experience around RTL? Happy to collaborate on improvements that are needed for RTL support.

Also, I'd like to invite you to join Crowdin, where we manage the translations.
Which email adress shall I use for the invite?

@m-mohr m-mohr changed the title Git checkout b feature/add Arabic Add Arabic locale Feb 24, 2025
@randa-11295
Copy link
Contributor Author

Thank you for your feedback! I’ll review your comments and make the needed improvements.

I have good experience with RTL since I work with both Arabic and English. I'd love to help improve RTL support.

It would be great to join the Crowdin community! Please send the invite to
[email protected]
Looking forward to contributing!

@randa-11295 randa-11295 requested a review from m-mohr February 24, 2025 22:37
@randa-11295
Copy link
Contributor Author

Thank you for your feedback! I’ve reviewed your comments and made the necessary updates:
-Fixed translation inconsistencies.
-Updated fields.json with accurate Arabic translations.
-Removed unnecessary comments from datepicker and duration components.
Let me know if there are any specific areas that still need adjustments.

@m-mohr m-mohr mentioned this pull request Feb 24, 2025
4 tasks
@m-mohr
Copy link
Collaborator

m-mohr commented Feb 24, 2025

Thank you very much, the PR looks very good now. I've sent you an invite to join the CrowdIn translation tool. If you did not receive it, please let me know and I'll resend it.

I have good experience with RTL since I work with both Arabic and English. I'd love to help improve RTL support.

Wonderful. I meant to ask, what's your experience with RTL in STAC Browser? I think we need some adjustments there to cater better for Arabic and RTL. For example, set the dir property in HTML. This likely needs a new config option in the config.js locales.
I've opened a separate issue where we can discuss further steps: #574 I'd be happy to collaborate with you on this issue. As you are a web dev, feel free to start a PR if you want.

Thanks again, I'll merge this for now.

@m-mohr m-mohr closed this Feb 24, 2025
@m-mohr m-mohr reopened this Feb 24, 2025
@m-mohr m-mohr merged commit 0ad1bd6 into radiantearth:main Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants