Slight improvement to magic snippet #1064
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should work on Emacs >= 23.1
raxod502
reviewed
Mar 12, 2023
There was a problem hiding this comment.
The minimum supported version of Emacs for straight.el is Emacs 25.1. In particular, Emacs versions 24.3 and below were never supported, even in 2017 when the project was first begun. Does it change anything to add backwards compatibility here?
|
Oh, I see. You're not adding backwards compatibility, you're just using a more readable function instead of |
raxod502
reviewed
Mar 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should work on Emacs >= 23.1
I don't think this needs a changelog, but please LMK if you disagree.