Merging #55
Merged
Merging #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
wow, seems like a good refactor. Need to test, but i would probably go forward and merge and wait for more PRs without bumping a new release of r2pipe yet.
what do you think?
… On 19 Mar 2018, at 15:13, Releev ***@***.***> wrote:
Hello! Did some work on merging r2pipe/python and r2pipe/python-async (now it's merged in r2/python, but r2pipe/python-async is still there without any changes).
There are still some issues with async code - it's throwing ignored exceptions when "Open" class is destroyed (as I think). Need some help to fix it.
Exception ignored in: <bound method BaseSubprocessTransport.__del__ of <_UnixSubprocessTransport closed pid=4931 running stdin=<_UnixWritePipeTransport closed fd=7 closed> stdout=<_UnixReadPipeTransport closing fd=9 open»>
May be related python/asyncio#473 <python/asyncio#473>
You can view, comment on, or merge this pull request online at:
#55 <#55>
Commit Summary
Some work done on merging python and python-async libs.
aww, that files
File Changes
M python/r2pipe/__init__.py <https://github.com/radare/radare2-r2pipe/pull/55/files#diff-0> (420)
A python/r2pipe/open_async.py <https://github.com/radare/radare2-r2pipe/pull/55/files#diff-1> (193)
A python/r2pipe/open_base.py <https://github.com/radare/radare2-r2pipe/pull/55/files#diff-2> (232)
A python/r2pipe/open_sync.py <https://github.com/radare/radare2-r2pipe/pull/55/files#diff-3> (94)
Patch Links:
https://github.com/radare/radare2-r2pipe/pull/55.patch <https://github.com/radare/radare2-r2pipe/pull/55.patch>
https://github.com/radare/radare2-r2pipe/pull/55.diff <https://github.com/radare/radare2-r2pipe/pull/55.diff>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub <#55>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA3-lp7mGsyPe2RI4JAY1eRAkxzRBgljks5tf7zrgaJpZM4SwO_h>.
|
|
Yep, it is fine!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! Did some work on merging r2pipe/python and r2pipe/python-async (now it's merged in r2pipe/python, but r2pipe/python-async is still there without any changes).
There are still some issues with async code - it's throwing ignored exceptions when "Open" class objects being destroyed (as I think). Need some help to fix it.
Exception ignored in: <bound method BaseSubprocessTransport.__del__ of <_UnixSubprocessTransport closed pid=4931 running stdin=<_UnixWritePipeTransport closed fd=7 closed> stdout=<_UnixReadPipeTransport closing fd=9 open»>May be related python/asyncio#473