Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

010124 rollup #19

Merged
merged 5 commits into from
Jul 24, 2024
Merged

010124 rollup #19

merged 5 commits into from
Jul 24, 2024

Conversation

omkhar
Copy link
Contributor

@omkhar omkhar commented Jan 1, 2024

roll up of patches for ease of application.

Contains:

#13
#14
#15
#16
#17

@r-pufky
Copy link
Owner

r-pufky commented Mar 4, 2024

Apologies for the delay in getting your changes reviewed and submitted; got busy with life stuff. I'm going to be pulling these in in the next few days.

Copy link
Owner

@r-pufky r-pufky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heya, thanks for being patient, just one bug that I found, and a few style/precedence things to update. Thanks for all the work!

echo nameserver "${IPV6DNS0}" >> /etc/resolv.conf
echo "nameserver ${IPV6DNS0}" >> /etc/resolv.conf
fi
if [ ! -z "${IPV4DNS1}" ]; then
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be IPV6DNS1 and below

#ALLOWED_IPS_6=fc10:4:0::0/128

#Set this if you need to force a different MTU than wireguard automatically sets
#WG_MTU=1200
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Explicitly set this to the default WG value; users can determine if they need to shorten it for use. The default value is 1420 (https://github.com/WireGuard/wireguard-tools/blob/13f4ac4cb74b5a833fa7f825ba785b1e5774e84f/src/wg-quick/linux.bash#L141).

Use active voice for comment to make it more succinct; and keep or wrap at 80 characters for readability. Something like Wireguard MTU size.

@@ -21,6 +21,7 @@ INTERFACE=example_vpn

# CIDR wireguard interface address.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use undefined vars to represent unset values. This requires more backend code to handle these cases but makes it easier for the user to to consume.

# Wireguard interface name. (leave blank to disable).
INTERFACE_ADDR=172.31.255.10/32
INTERFACE_ADDR_6=

# Allowed IP's (CIDR) on wireguard; for boot this should be the peer (server) (leave blank to disable).
ALLOWED_IPS=172.31.255.254/32
ALLOWED_IPS_6=

# Persist wireguard interface after initramfs exits (leave blank to disable).
PERSISTENT=Y

@r-pufky r-pufky modified the milestone: Standardize roll for galaxy-ng integration (4.x) Apr 4, 2024
@r-pufky r-pufky merged commit 7afee53 into r-pufky:main Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants