Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace mockery #60

Closed

Conversation

maurolepore
Copy link

@maurolepore maurolepore commented Aug 15, 2024

Closes #57

This PR is part of the tidyverse developer day. It removes mockery as a dependency but turned out quite messy. Feel free to close it. No hurt feelings :-)

In particular here are potential problems I see:

  • The tests may not expose some problems. Many tests are called via a wrapper to test_that() which I didn't fully understand. Some tests seem to fail interactively but don't fail when calling test().
  • In R/git-auth.R I messed up the order in which the functions are defined, sorry :-(.
  • local() still has some functions. If local() was necessary to support mockery, then removing mockery should result in extracting all functions out of local() but that's not the case.
  • R CMD check and test coverage fail on GitHub Actions for Windows and MacOS.

@gaborcsardi
Copy link
Member

Thanks for taking a stab at this! It seems like this is more difficult than I anticipated, so I am going to close this now, and may take another look later. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use testthat::with_mock() instead of mockery
2 participants