Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page Bookmarks – Model Migrations #682

Closed

Conversation

mohannad-hassan
Copy link
Collaborator

@mohannad-hassan mohannad-hassan commented Jan 28, 2025

This PR introduces the needed changes in the page bookmarks table: adding an optional remoteID. This will be used to identify the bookmarks in APIs with the backend.

Additionally, the PR enables automatic data migrations for the model. The changes are simple, so the automatic migration is sufficient.

Not in this PR: the tracking of local mutations; either the table that tracks unsynced mutations or the any model or service changes.

@mohannad-hassan mohannad-hassan marked this pull request as ready for review January 28, 2025 01:31
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 55.55556% with 4 lines in your changes missing coverage. Please review.

Project coverage is 40.79%. Comparing base (d9fc366) to head (fec2125).
Report is 42 commits behind head on main.

Files with missing lines Patch % Lines
...notationsService/Sources/PageBookmarkService.swift 0.00% 2 Missing ⚠️
Model/QuranAnnotations/PageBookmark.swift 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #682      +/-   ##
==========================================
- Coverage   40.92%   40.79%   -0.14%     
==========================================
  Files         525      539      +14     
  Lines       20880    21691     +811     
==========================================
+ Hits         8546     8848     +302     
- Misses      12334    12843     +509     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mohamede1945
Copy link
Collaborator

I'm not sure what is this PR for. Could you please add description?

Also theoretically, migration should be at the final stages when we develop a robust sync layer with quran.com, but maybe the description could clarify what this is about.

Thank you!

@mohannad-hassan mohannad-hassan changed the title Page Bookmarks – Migrations Page Bookmarks – Model Migrations Jan 29, 2025
@mohannad-hassan
Copy link
Collaborator Author

I'm not sure what is this PR for. Could you please add description?

Also theoretically, migration should be at the final stages when we develop a robust sync layer with quran.com, but maybe the description could clarify what this is about.

Thank you!

@mohamede1945 Updated. Let me know if anything is missing.

Note that this migration step is needed right now. We might have to do further migration steps related to the synchronisation logic.

@mohannad-hassan mohannad-hassan deleted the page-bookmarks-migrations branch February 18, 2025 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants